On Wed, 2015-09-23 at 08:15 -0700, David Ahern wrote: > ip_route_input_slow is a maze of gotos (9 of them!) making it error > prone and difficult to read. This patchset refactors it, removing all > but 2 of the labels. The brd_input label for broadcast path requires > too many inputs to make a reasonble helper out of it so I left it as is. > > None of these patches change functionality, only move code around > to make ip_route_input_slow more readable.
This kind of work, might ease your job (pushing new functions in the future kernels), but make stable teams work a nightmare. You also remove a lot of goto, but do not place likely() or unlikely() clauses that would help compiler to emit the same optimal code. gotos have quite nice properties, forget what you might have learn in some CS classes. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
