On Wed, 19 Aug 2015 19:17:21 +0900, YOSHIFUJI Hideaki wrote:
> Jiri Benc wrote:
> > Allow specification of per route IP tunnel instructions also for IPv6.
> > This complements commit 3093fbe7ff4b ("route: Per route IP tunnel metadata
> > via lightweight tunnel").
> >
> > Signed-off-by: Jiri Benc <jb...@redhat.com>
> > ---
> > include/uapi/linux/lwtunnel.h | 16 +++++++
> > net/ipv4/ip_tunnel_core.c | 102
> > ++++++++++++++++++++++++++++++++++++++++++
> > 2 files changed, 118 insertions(+)
> >
> > diff --git a/include/uapi/linux/lwtunnel.h b/include/uapi/linux/lwtunnel.h
> > index aa84ca396bcb..32a149571417 100644
> > --- a/include/uapi/linux/lwtunnel.h
> > +++ b/include/uapi/linux/lwtunnel.h
> > @@ -7,6 +7,7 @@ enum lwtunnel_encap_types {
> > LWTUNNEL_ENCAP_NONE,
> > LWTUNNEL_ENCAP_MPLS,
> > LWTUNNEL_ENCAP_IP,
> > + LWTUNNEL_ENCAP_IP6,
> > LWTUNNEL_ENCAP_ILA,
> > __LWTUNNEL_ENCAP_MAX,
> > };
>
> Please do not add new one in the middle of enums.
You're right generally. But this one should be okay and I did this
deliberately: the patch adding LWTUNNEL_ENCAP_ILA was merged two days
ago, is in net-next only, is not used by anything in user space yet.
And I think it's better to have LWTUNNEL_ENCAP_IP and
LWTUNNEL_ENCAP_IP6 without anything in between.
Thanks,
Jiri
--
Jiri Benc
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
