On Sunday 24 February 2008, Sam Ravnborg wrote: > From a quick look this is wrong. > smc_drv_probe is assined the .probe member so it is used during > hotplug and thus should be __devinit. > Likewise smc_probe is used by smc_drv_probe and thus smc_probe > should be __devinit too.
Thing is, with only rare exceptions, devices on the platform bus are *NOT* hotpluggable. So using __devinit/__devexit and friends adds up to no more than a waste of I-space. Nico may know if this driver is one of the rare exceptions. Example, is it used in PCMCIA cards? See also platform_driver_probe(), which is a much safer way to handle such issues. I've seen it save a full page in some drivers, but usually it's less. - Dave -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
