From: "Ramkrishna Vepa" <[EMAIL PROTECTED]> Date: Tue, 8 Jan 2008 18:01:32 -0500
> Dave, > Sorry, should have been clearer. When I meant "brought down" did not > mean close, but when a adapter reset is initiated. The napi_disable() is > called only on a close. When the driver does a reset, napi_disable() is > not called. You should be doing a napi_disable() during a reset, like every other driver does. It is the only reliable way to prevent the code path from running. Otherwise, you can start resetting the device right after that check in the ->poll() routine, and thus still touch the device during the reset sequence. In short the check is wrong, because it doesn't fully prevent what you want it to prevent. Only a napi_disable() would do that fully for you. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
