Dave, Sorry, should have been clearer. When I meant "brought down" did not mean close, but when a adapter reset is initiated. The napi_disable() is called only on a close. When the driver does a reset, napi_disable() is not called.
Ram > -----Original Message----- > From: David Miller [mailto:[EMAIL PROTECTED] > Sent: Tuesday, January 08, 2008 2:48 PM > To: Ramkrishna Vepa > Cc: netdev@vger.kernel.org > Subject: Re: [PATCH 3/7]: [NET]: Do not check netif_running() and carrier > state in ->poll() > > From: "Ramkrishna Vepa" <[EMAIL PROTECTED]> > Date: Tue, 8 Jan 2008 13:17:03 -0500 > > > Dave, > > > > This change is not required as the macro, is_s2io_card_up() checks for > > an internal state of the adapter and not netif's state. We want to make > > sure that the adapter registers are not accessed when the adapter is > > being brought down. > > If the adapter is being brought down, you would have done > a napi_disable() first and therefore never reach this code > path. > > The removal is correct, I read how your driver works. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
