On Thu, Mar 25, 2021 at 07:07:26PM -0700, Jakub Kicinski wrote:
> Reject NONE on set, this mode means device does not support
> FEC so it's a little out of place in the set interface.
>
> This should be safe to do - user space ethtool does not allow
> the use of NONE on set. A few drivers treat it the same as OFF,
> but none use it instead of OFF.
>
> Similarly reject an empty FEC mask. The common user space tool
> will not send such requests and most drivers correctly reject
> it already.
>
> v2: - use mask not bit pos
>
> Signed-off-by: Jakub Kicinski <k...@kernel.org>
Reviewed-by: Andrew Lunn <and...@lunn.ch>
Andrew
