On Fri, 19 Mar 2021 16:57:09 +0100, Michael Tretter wrote:
> The DP83867 supports four configurable LED pins. Describe the
> multiplexing of functions to the LEDs via device tree.
>
> Signed-off-by: Michael Tretter <[email protected]>
> ---
> .../devicetree/bindings/net/ti,dp83867.yaml | 24 +++++++++++++++++++
> include/dt-bindings/net/ti-dp83867.h | 16 +++++++++++++
> 2 files changed, 40 insertions(+)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/ti,dp83867.yaml:
properties:ti,dp83867-led-mode-names:items: 'anyOf' conditional failed, one
must be fixed:
{'anyOf': {'items': [{'const': 'led-0'}, {'const': 'led-1'}, {'const':
'led-2'}, {'const': 'led-gpio'}]}} is not of type 'array'
{'items': [{'const': 'led-0'}, {'const': 'led-1'}, {'const': 'led-2'},
{'const': 'led-gpio'}]} is not of type 'array'
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/ti,dp83867.yaml:
properties:ti,dp83867-led-mode-names:items: {'anyOf': {'items': [{'const':
'led-0'}, {'const': 'led-1'}, {'const': 'led-2'}, {'const': 'led-gpio'}]}} is
not of type 'array'
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/ti,dp83867.yaml:
properties:ti,dp83867-led-mode-names:items: 'oneOf' conditional failed, one
must be fixed:
{'anyOf': {'items': [{'const': 'led-0'}, {'const': 'led-1'}, {'const':
'led-2'}, {'const': 'led-gpio'}]}} is not of type 'array'
{'items': [{'const': 'led-0'}, {'const': 'led-1'}, {'const': 'led-2'},
{'const': 'led-gpio'}]} is not of type 'array'
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/ti,dp83867.yaml:
ignoring, error in schema: properties: ti,dp83867-led-mode-names: items
warning: no schema found in file:
./Documentation/devicetree/bindings/net/ti,dp83867.yaml
See https://patchwork.ozlabs.org/patch/1455937
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
