On Fri, Mar 19, 2021 at 04:57:08PM +0100, Michael Tretter wrote: > Hello, > > The dp83867 has 4 LED pins, which can be multiplexed with different functions > of the phy. > > This series adds a device tree binding to describe the multiplexing of the > functions to the LEDs and implements the binding for the dp83867 phy. > > I found existing bindings for configuring the LED modes for other phys: > > In Documentation/devicetree/bindings/net/micrel.txt, the binding is not > flexible enough for the use case in the dp83867, because there is a value for > each LED configuration, which would be a lot of values for the dp83867. > > In Documentation/devicetree/bindings/net/mscc-phy-vsc8532.txt, there is a > separate property for each LED, which would work, but I found rather > unintuitive compared to how clock bindings etc. work. > > The new binding defines two properties: one for the led names and another > property for the modes of the LEDs with defined values in the same order. > Currently, the binding is specific to the dp83867, but I guess that the > binding could be made more generic and used for other phys, too.
There is some work going on to manage PHY LEDs just like other LEDs in Linux, using /sys/class/leds. Please try to help out with that work, rather than adding yet another DT binding. Andrew
