On Tue, 2021-02-02 at 13:24 -0800, Jakub Kicinski wrote: > On Mon, 01 Feb 2021 23:31:15 -0800 Saeed Mahameed wrote:
... > > > > Jakub, it is not only about installation dependencies, the issue is > > more critical than this, > > > > We had some other issues with similar dependency problem where > > mlx5_core had hard dependency with netfilter, firewalld when > > disabled, > > removes netfilter and all its dependencies including mlx5, this is > > a no > > go for our users. > > > > Again, having a hard dependency between a hardware driver and a > > peripheral module in the kernel is a bad design. > > That is not the point. > > The technical problem is minor, and it's a problem for _your_ driver. > Yet, it appears to be my responsibility to make sure the patch even > compiles. > I understand your frustration, We should have been more professional with this patch submission, > I believe there should be a limit to the ignorance a community > volunteer is expected to put up with when dealing with patches > from and for the benefit of a commercial vendor. > totally agree, we have the tools internally to avoid clutter in mailing list and we do this for pure mlx5 patches, but for net patches, people tend to hurry and skip the queue so they get feedback ASAP.. this doesn't make it right, I will work to improve this. > This is up for discussion, if you disagree let's talk it out. I'm > not particularly patient (to put it mildly), but I don't understand > how v5 could have built, and yet v6 gets posted with the same exact > problem :/ > given the circumstance i would've done the same, even on v4.. sorry for the inconvenience .. :(.. thanks for your patience. > So from my perspective it seems like the right step to push back. And I back you up ! > If you, Tariq, Jiri, Ido or any other seasoned kernel contributor > reposts this after making sure it's up to snuff themselves I will > most certainly take a look / apply. My point wasn't about psample, it's about hw drivers vs stack/modules dependency in general, maybe I used the wrong patch to discuss this matter :D.. I will post a separate RFC for discussion later not related to psample at all. this patch smells so bad we can't even discuss the general issue here .. Again thanks for your review and patience.
