On Mon, 2021-02-01 at 17:14 -0800, Jakub Kicinski wrote: > On Mon, 1 Feb 2021 10:04:12 +0800 Chris Mi wrote: > > In order to send sampled packets to userspace, NIC driver calls > > psample api directly. But it creates a hard dependency on module > > psample. Introduce psample_ops to remove the hard dependency. > > It is initialized when psample module is loaded and set to NULL > > when the module is unloaded. > > > > Reported-by: kernel test robot <l...@intel.com> > > Signed-off-by: Chris Mi <c...@nvidia.com> > > Reviewed-by: Jiri Pirko <j...@nvidia.com> > > The necessity of making this change is not obvious (you can fix the > distro scripts instead), you did not include a clarification in the > commit message even though two people asked you why it's needed and > on top of that you keep sending code which doesn't build. > > Please consider this change rejected and do not send a v7.
Jakub, it is not only about installation dependencies, the issue is more critical than this, We had some other issues with similar dependency problem where mlx5_core had hard dependency with netfilter, firewalld when disabled, removes netfilter and all its dependencies including mlx5, this is a no go for our users. Again, having a hard dependency between a hardware driver and a peripheral module in the kernel is a bad design.
