On Thu, 28 Jan 2021 00:19:48 -0800 Saeed Mahameed wrote:
> On Wed, 2021-01-27 at 19:54 -0800, Jakub Kicinski wrote:
> > On Tue, 26 Jan 2021 15:24:06 -0800 Saeed Mahameed wrote:  
> > > From: Aya Levin <a...@nvidia.com>
> > > 
> > > Add packet trap that can report packets that were dropped due to
> > > destination MAC filtering.
> > > 
> > > Signed-off-by: Aya Levin <a...@nvidia.com>
> > > Reviewed-by: Ido Schimmel <ido...@nvidia.com>
> > > Reviewed-by: Moshe Shemesh <mo...@nvidia.com>
> > > Reviewed-by: Tariq Toukan <tar...@nvidia.com>
> > > Signed-off-by: Tariq Toukan <tar...@nvidia.com>
> > > Signed-off-by: Saeed Mahameed <sae...@nvidia.com>
> > 
> > s/in case/because/
> >   
> > > +       the destination MAC is not configured in the MAC table  
> > 
> > ... and the interface is not in promiscuous mode
> >   
> 
> Makes sense ! 
> 
> > > +  
> > 
> > Double new line
> >   
> > >  Driver-specific Packet Traps
> > >  ============================  
> > 
> > Fix that up and applied from the list.  
> 
> Thanks,
> I can stop sending pull requests and siwtch to normal patchsets 
> if this will be more convenient to you/
> 
> to me is just converting the cover letter :).. 

No preference on my side, as long as the patches are on the ML it's just
the matter of remembering which parameters to pass to my scripts :)

Reply via email to