On Wed, 2021-01-27 at 19:54 -0800, Jakub Kicinski wrote: > On Tue, 26 Jan 2021 15:24:06 -0800 Saeed Mahameed wrote: > > From: Aya Levin <a...@nvidia.com> > > > > Add packet trap that can report packets that were dropped due to > > destination MAC filtering. > > > > Signed-off-by: Aya Levin <a...@nvidia.com> > > Reviewed-by: Ido Schimmel <ido...@nvidia.com> > > Reviewed-by: Moshe Shemesh <mo...@nvidia.com> > > Reviewed-by: Tariq Toukan <tar...@nvidia.com> > > Signed-off-by: Tariq Toukan <tar...@nvidia.com> > > Signed-off-by: Saeed Mahameed <sae...@nvidia.com> > > --- > > Documentation/networking/devlink/devlink-trap.rst | 5 +++++ > > include/net/devlink.h | 3 +++ > > net/core/devlink.c | 1 + > > 3 files changed, 9 insertions(+) > > > > diff --git a/Documentation/networking/devlink/devlink-trap.rst > > b/Documentation/networking/devlink/devlink-trap.rst > > index d875f3e1e9cf..1dd86976ecf8 100644 > > --- a/Documentation/networking/devlink/devlink-trap.rst > > +++ b/Documentation/networking/devlink/devlink-trap.rst > > @@ -480,6 +480,11 @@ be added to the following table: > > - ``drop`` > > - Traps packets that the device decided to drop in case they > > hit a > > blackhole nexthop > > + * - ``dmac_filter`` > > + - ``drop`` > > + - Traps incoming packets that the device decided to drop in > > case > > s/in case/because/ > > > + the destination MAC is not configured in the MAC table > > ... and the interface is not in promiscuous mode >
Makes sense ! > > + > > Double new line > > > Driver-specific Packet Traps > > ============================ > > Fix that up and applied from the list. Thanks, I can stop sending pull requests and siwtch to normal patchsets if this will be more convenient to you/ to me is just converting the cover letter :)..