On Thu, 7 Jan 2021 12:28:38 -0800 Saeed Mahameed wrote:
> + int ret;
> +
> + counter = kzalloc(sizeof(*counter), GFP_KERNEL);
> + if (!counter)
> + return ERR_PTR(-ENOMEM);
> +
> + counter->is_shared = false;
> + counter->counter = mlx5_fc_create(ct_priv->dev, true);
> + if (IS_ERR(counter->counter)) {
> + ct_dbg("Failed to create counter for ct entry");
> + ret = PTR_ERR(counter->counter);
> + kfree(counter);
> + return ERR_PTR(ret);
The err ptr -> ret -> err ptr conversion seems entirely pointless, no?
