Hi Jakub, > -----Original Message----- > From: Jakub Kicinski <k...@kernel.org> > Sent: Monday, November 2, 2020 11:25 PM > To: Naveen Mamindlapalli <nave...@marvell.com> > Cc: netdev@vger.kernel.org; linux-ker...@vger.kernel.org; > da...@davemloft.net; Sunil Kovvuri Goutham <sgout...@marvell.com>; Linu > Cherian <lcher...@marvell.com>; Geethasowjanya Akula > <gak...@marvell.com>; Jerin Jacob Kollanukkaran <jer...@marvell.com>; > Subbaraya Sundeep Bhatta <sbha...@marvell.com>; Hariprasad Kelam > <hke...@marvell.com>; Tomasz Duszynski <tduszyn...@marvell.com> > Subject: Re: [PATCH net-next 10/13] octeontx2-pf: Add support for SR-IOV > management functions > > On Mon, 2 Nov 2020 11:41:19 +0530 Naveen Mamindlapalli wrote: > > This patch adds support for ndo_set_vf_mac, ndo_set_vf_vlan and > > ndo_get_vf_config handlers. The traffic redirection based on the VF > > mac address or vlan id is done by installing MCAM rules. Reserved > > RX_VTAG_TYPE7 in each NIXLF for VF VLAN which strips the VLAN tag from > > ingress VLAN traffic. The NIX PF allocates two MCAM entries for VF > > VLAN feature, one used for ingress VTAG strip and another entry for > > egress VTAG insertion. > > > > This patch also updates the MAC address in PF installed VF VLAN rule > > upon receiving nix_lf_start_rx mbox request for VF since > > Administrative Function driver will assign a valid MAC addr in > > nix_lf_start_rx function. > > > > Signed-off-by: Naveen Mamindlapalli <nave...@marvell.com> > > Co-developed-by: Tomasz Duszynski <tduszyn...@marvell.com> > > Signed-off-by: Tomasz Duszynski <tduszyn...@marvell.com> > > Signed-off-by: Sunil Goutham <sgout...@marvell.com> > > Signed-off-by: Hariprasad Kelam <hke...@marvell.com> > > drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c:2097:31: warning: cast > to restricted __be16 > drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c:2097:31: warning: cast > to restricted __be16 > drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c:2097:31: warning: cast > to restricted __be16 > drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c:2097:31: warning: cast > to restricted __be16 > drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c:2158:55: warning: > incorrect type in argument 5 (different base types) > drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c:2158:55: expected > unsigned short [usertype] proto > drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c:2158:55: got > restricted > __be16 [usertype] proto > 203a211,214 > drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c: In function > ‘npc_update_dmac_value’: > drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c:1236:24: warning: > implicit conversion from ‘enum header_fields’ to ‘enum key_fields’ [-Wenum- > conversion] > 1236 | npc_update_entry(rvu, NPC_DMAC, entry, > | ^~~~~~~~
I will fix these warnings in v2. Thanks, Naveen
