Hi Jakub, > -----Original Message----- > From: Jakub Kicinski <k...@kernel.org> > Sent: Monday, November 2, 2020 11:24 PM > To: Naveen Mamindlapalli <nave...@marvell.com> > Cc: netdev@vger.kernel.org; linux-ker...@vger.kernel.org; > da...@davemloft.net; Sunil Kovvuri Goutham <sgout...@marvell.com>; Linu > Cherian <lcher...@marvell.com>; Geethasowjanya Akula > <gak...@marvell.com>; Jerin Jacob Kollanukkaran <jer...@marvell.com>; > Subbaraya Sundeep Bhatta <sbha...@marvell.com>; Hariprasad Kelam > <hke...@marvell.com> > Subject: Re: [PATCH net-next 03/13] octeontx2-af: Generate key field bit > mask from KEX profile > > On Mon, 2 Nov 2020 11:41:12 +0530 Naveen Mamindlapalli wrote: > > From: Subbaraya Sundeep <sbha...@marvell.com> > > > > Key Extraction(KEX) profile decides how the packet metadata such as > > layer information and selected packet data bytes at each layer are > > placed in MCAM search key. This patch reads the configured KEX profile > > parameters to find out the bit position and bit mask for each field. > > The information is used when programming the MCAM match data by SW to > > match a packet flow and take appropriate action on the flow. This > > patch also verifies the mandatory fields such as channel and DMAC are > > not overwritten by the KEX configuration of other fields. > > > > Signed-off-by: Subbaraya Sundeep <sbha...@marvell.com> > > Signed-off-by: Sunil Goutham <sgout...@marvell.com> > > Signed-off-by: Naveen Mamindlapalli <nave...@marvell.com> > > Lots of new warnings like this here: > > drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c:351:38: warning: > implicit conversion from ‘enum header_fields’ to ‘enum key_fields’ [-Wenum- > conversion] > 351 | if (npc_check_overlap(rvu, blkaddr, NPC_ETYPE, start_lid, intf)) > | ^~~~~~~~~
I will fix these warnings in v2. Thanks, Naveen