On Sat, Oct 31, 2020 at 7:33 AM Willem de Bruijn <willemdebruijn.ker...@gmail.com> wrote: > > > - rx_error: > > +rx_error: > > frad->stats.rx_errors++; /* Mark error */ > > +rx_drop: > > dev_kfree_skb_any(skb); > > return NET_RX_DROP; > > I meant that I don't think errors should be double counted in rx_error > and rx_drop. It is fine to count drops as either.
OK. Can we do that in another patch? Because I feel this would make the code a little bit more complex. Let's keep this patch as only a simple clean-up. > Especially without that, I'm not sure this and the follow-on patch add > much value. Minor code cleanups complicate backports of fixes. To me this is necessary, because I feel hard to do any development on un-cleaned-up code. I really don't know how to add my code without these clean-ups, and even if I managed to do that, I would not be happy with my code.
