On Fri, Oct 30, 2020 at 8:49 PM Xie He <xie.he.0...@gmail.com> wrote: > > 1. > Change the skb->len check from "<= 4" to "< 4". > At first we only need to ensure a 4-byte header is present. We indeed > normally need the 5th byte, too, but it'd be more logical and cleaner > to check its existence when we actually need it. > > 2. > Add an fh->ea2 check to the initial checks in fr_rx. fh->ea2 == 1 means > the second address byte is the final address byte. We only support the > case where the address length is 2 bytes. If the address length is not > 2 bytes, the control field and the protocol field would not be the 3rd > and 4th byte as we assume. (Say it is 3 bytes, then the control field > and the protocol field would be the 4th and 5th byte instead.) > > Cc: Willem de Bruijn <willemdebruijn.ker...@gmail.com> > Cc: Krzysztof Halasa <k...@pm.waw.pl> > Signed-off-by: Xie He <xie.he.0...@gmail.com>
Acked-by: Willem de Bruijn <will...@google.com>
