On 10/9/20 2:51 AM, Jakub Kicinski wrote:
> On Tue,  6 Oct 2020 15:52:53 +0200 Marek Vasut wrote:
>> The phy_reset_after_clk_enable() does a PHY reset, which means the PHY
>> loses its register settings. The fec_enet_mii_probe() starts the PHY
>> and does the necessary calls to configure the PHY via PHY framework,
>> and loads the correct register settings into the PHY. Therefore,
>> fec_enet_mii_probe() should be called only after the PHY has been
>> reset, not before as it is now.
>>
>> Fixes: 1b0a83ac04e3 ("net: fec: add phy_reset_after_clk_enable() support")
>> Reviewed-by: Andrew Lunn <and...@lunn.ch>
>> Tested-by: Richard Leitner <richard.leit...@skidata.com>
>> Signed-off-by: Marek Vasut <ma...@denx.de>
> 
> Is moving the reset before fec_enet_mii_probe() the reason you need the
> second patch?
> 
>   net: fec: Fix phy_device lookup for phy_reset_after_clk_enable()

No, the second patch addresses separate issue.

Reply via email to