From: Erik Hovland <[EMAIL PROTECTED]> Date: Wed, 18 Apr 2007 16:18:15 -0700
> Heh, the reason I came up with this patch is that the code in > drivers/usb/gadget/ether.c at about line 1653 will attempt to allocate > an skb. If it fails then it uses a goto to jump to line 1672 where it > will call dev_kfree_skb_any (skb) on a potentially null skb. I put a > validity check there and sent it off to the USB gadget maintainer. He > asked me to instead make the dev_kfree_skb_any call more robust and see > how that went over on the netdev list. Like a lead balloon? Yep, like a lead baloon. The USB gadget driver maintainer should accept your patch to check for NULL in the gadget driver as that is the one and only case in the entire tree where that can happen and we're not eating a conditional and a return just for that one esoteric case. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
