On Wed, Apr 18, 2007 at 03:44:16PM -0700, David Miller wrote: > From: Erik Hovland <[EMAIL PROTECTED]> > Date: Wed, 18 Apr 2007 15:33:44 -0700 > > > If dev_kfree_skb_any is called and it then calls dev_kfree_skb_irq. > > That call will dereference the skb. If the skb is invalid, down the > > drain we go. > > > > This one-liner checks to see if the skb is valid as part of the > > determination of whether to call dev_kfree_skb_irq. > > > > Signed-off-by: Erik Hovland <[EMAIL PROTECTED]> > > This should never be invoked with a NULL skb argument. > > Who is doing that?
Heh, the reason I came up with this patch is that the code in drivers/usb/gadget/ether.c at about line 1653 will attempt to allocate an skb. If it fails then it uses a goto to jump to line 1672 where it will call dev_kfree_skb_any (skb) on a potentially null skb. I put a validity check there and sent it off to the USB gadget maintainer. He asked me to instead make the dev_kfree_skb_any call more robust and see how that went over on the netdev list. Like a lead balloon? E -- Erik Hovland mail: [EMAIL PROTECTED] web: http://hovland.org/ PGP/GPG public key available on request - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
