On Fri, 2020-10-02 at 07:40 -0700, Jakub Kicinski wrote: > > I suppose you could make an argument that only some attrs might be > > accepted in doit and somewhat others in dumpit, or perhaps none in > > dumpit because filtering wasn't implemented? > > Right? Feels like it goes against our strict validation policy to > ignore input on dumpit. > > > But still ... often we treat filtering as "advisory" anyway (except > > perhaps where there's no doit at all, like the dump_policy thing here), > > so it wouldn't matter if some attribute is ending up ignored? > > It may be useful for feature discovery to know if an attribute is > supported.
Fair point. > I don't think it matters for any user right now, but maybe we should > require user space to specify if they are interested in normal req > policy or dump policy? That'd give us the ability to report different > ones in the future when the need arises. Or just give them both? I mean, in many (most?) cases they're anyway going to be the same, so with the patches I posted you could just give them the two different policy indexes, and they can be the same? But whichever, doesn't really matter much. johannes
