On Fri, 02 Oct 2020 08:29:27 +0200 Johannes Berg wrote: > On Thu, 2020-10-01 at 17:36 -0700, Jakub Kicinski wrote: > > Do we need support for separate .doit and .dumpit policies? > > Or is that an overkill? > > I suppose you could make an argument that only some attrs might be > accepted in doit and somewhat others in dumpit, or perhaps none in > dumpit because filtering wasn't implemented?
Right? Feels like it goes against our strict validation policy to ignore input on dumpit. > But still ... often we treat filtering as "advisory" anyway (except > perhaps where there's no doit at all, like the dump_policy thing here), > so it wouldn't matter if some attribute is ending up ignored? It may be useful for feature discovery to know if an attribute is supported. I don't think it matters for any user right now, but maybe we should require user space to specify if they are interested in normal req policy or dump policy? That'd give us the ability to report different ones in the future when the need arises.