On Mon, Sep 21, 2020 at 07:07:21PM +0200, Andrew Lunn wrote:
> On Mon, Sep 21, 2020 at 07:20:31PM +0300, Ioana Ciornei wrote:
> > +static void dpaa2_pcs_destroy(struct dpaa2_mac *mac)
> > +{
> > + struct lynx_pcs *pcs = mac->pcs;
> > +
> > + if (pcs) {
> > + put_device(&pcs->mdio->dev);
> > + lynx_pcs_destroy(pcs);
> > + mac->pcs = NULL;
>
> Hi Ioana
>
> Maybe the put_device() should come after the destroy? It is then the
> reverse of the creation.
>
> Andrew
Hi Andrew,
The lynx_pcs_destroy() function doesn't do much with the pcs, just a
kfree on it. I did it this way to avoid keeping the device in a
temporary variable but if you think we should do this in a symetrical
way, I can make the change.
Ioana
