Re: [PATCH net-next 3/3] dpaa2-mac: add PCS support through the Lynx module

[Andrew Lunn]

On Mon, Sep 21, 2020 at 07:20:31PM +0300, Ioana Ciornei wrote:
> +static void dpaa2_pcs_destroy(struct dpaa2_mac *mac)
> +{
> +     struct lynx_pcs *pcs = mac->pcs;
> +
> +     if (pcs) {
> +             put_device(&pcs->mdio->dev);
> +             lynx_pcs_destroy(pcs);
> +             mac->pcs = NULL;

Hi Ioana

Maybe the put_device() should come after the destroy? It is then the
reverse of the creation.

        Andrew