On 2020-09-04 01:46, Jakub Kicinski wrote:
On Thu, 3 Sep 2020 14:00:18 -0700 Saeed Mahameed wrote:+static inline void mlx5e_tx_wi_consume_fifo_skbs(struct mlx5e_txqsq *sq, + struct mlx5e_tx_wqe_info *wi, + struct mlx5_cqe64 *cqe, + int napi_budget) +{ + int i; + + for (i = 0; i < wi->num_fifo_pkts; i++) { + struct sk_buff *skb = mlx5e_skb_fifo_pop(sq); + + mlx5e_consume_skb(sq, skb, cqe, napi_budget); + } +}The compiler was not inlining this one either?
Regarding this one, gcc inlines it automatically, but I went on the safe side and inlined it explicitly - it's small and called for every WQE, so we never want it to be non-inline.
