On Tue, Sep 1, 2020 at 9:14 PM Florian Fainelli <f.faine...@gmail.com> wrote:
> On 9/1/2020 12:08 PM, Linus Walleij wrote:

> [snip]
>
> > +     /* Update the MC entry */
> > +     vlanmc.member |= member;
> > +     vlanmc.untag |= untag;
> > +     vlanmc.fid = fid;
>
> Is not there a problem with rtl8366_vlan_del() which is clearing the
> entire vlanmc structure when it it should be doing:
>
>         vlanmc.member &= ~BIT(port);
>         vlanmc.untag &= ~BIT(port);
>
> or something along these lines?

You're right, I'll send a separate patch for this.

Yours,
Linus Walleij

Reply via email to