On 9/1/2020 12:08 PM, Linus Walleij wrote:
The VLANs and PVIDs on the RTL8366 utilizes a "member
configuration" (MC) which is largely unexplained in the
code.
This set-up requires a special ordering: rtl8366_set_pvid()
must be called first, followed by rtl8366_set_vlan(),
else the MC will not be properly allocated. Relax this
by factoring out the code obtaining an MC and reuse
the helper in both rtl8366_set_pvid() and
rtl8366_set_vlan() so we remove this strict ordering
requirement.
In the process, add some better comments and debug prints
so people who read the code understand what is going on.
Signed-off-by: Linus Walleij <linus.wall...@linaro.org>
Reviewed-by: Florian Fainelli <f.faine...@gmail.com>
One question below:
[snip]
+ /* Update the MC entry */
+ vlanmc.member |= member;
+ vlanmc.untag |= untag;
+ vlanmc.fid = fid;
Is not there a problem with rtl8366_vlan_del() which is clearing the
entire vlanmc structure when it it should be doing:
vlanmc.member &= ~BIT(port);
vlanmc.untag &= ~BIT(port);
or something along these lines?
--
Florian
