On Thu, 20 Aug 2020 16:49:54 -0700 Luke Hsiao wrote:
> +     /* If reading from MSG_ERRQUEUE using recvmsg, ignore POLLIN */
> +     if (req->opcode == IORING_OP_RECVMSG && (sqe->msg_flags & MSG_ERRQUEUE))
> +             mask &= ~(POLLIN);

FWIW this adds another W=1 C=1 warnings to this code:

fs/io_uring.c:4940:22: warning: invalid assignment: &=
fs/io_uring.c:4940:22:    left side has type restricted __poll_t
fs/io_uring.c:4940:22:    right side has type int


And obviously the brackets around POLLIN are not necessary.

Reply via email to