On 3/27/07, David Miller <[EMAIL PROTECTED]> wrote:
From: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]>
Date: Tue, 27 Mar 2007 16:41:48 -0300
> +static inline void skb_move_linear_data(const struct sk_buff *skb,
> + const int from_offset,
> + const int to_offset,
> + const unsigned int len)
> +{
> + memcpy(skb->data + to_offset, skb->data + from_offset, len);
> +}
> +
What do you intend to use this for? There are no users in
your patch, and I'd be fearful of overlapping cases (which
ought to be common for anything using this) which therefore
would require use of memmove() instead of memcpy().
How about we just leave out interfaces until we have a use
case?
It should be ok now, please take a look in a throwaway branch to make
sure, sorry for the disturbance.
- Arnaldo
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html