> On Jul 30, 2020, at 2:16 PM, Andrii Nakryiko <andrii.nakry...@gmail.com>
> wrote:
>
> On Thu, Jul 30, 2020 at 2:13 PM Song Liu <songliubrav...@fb.com> wrote:
>>
>>
>>
>>> On Jul 29, 2020, at 4:05 PM, Andrii Nakryiko <andr...@fb.com> wrote:
>>>
>>> Add info on link detach sub-command to man page. Add detach to
>>> bash-completion
>>> as well.
>>>
>>> Signed-off-by: Andrii Nakryiko <andr...@fb.com>
>>
>> Acked-by: Song Liu <songliubrav...@fb.com>
>>
>> With one nitpick below.
>>
>>> ---
>>
>> [...]
>>
>>> @@ -49,6 +50,13 @@ DESCRIPTION
>>> contain a dot character ('.'), which is reserved for future
>>> extensions of *bpffs*.
>>>
>>> + **bpftool link detach** *LINK*
>>> + Force-detach link *LINK*. BPF link and its underlying BPF
>>> + program will stay valid, but they will be detached from the
>>> + respective BPF hook and BPF link will transition into
>>> + a defunct state until last open file descriptor for that
>>
>> Shall we say "a defunct state when the last open file descriptor for
>> that..."?
>
>
> No-no, it is in defunc state between LINK_DETACH and last FD being
> closed. Once last FD is closed, BPF link will get destructed and freed
> in kernel. So I think until is more precise here?
Ah, I see. I misunderstood "defunct state". Please ignore the comment.
Thanks,
Song
