Re: [PATCH bpf-next 5/5] tools/bpftool: add documentation and bash-completion for `link detach`

[Song Liu]

> On Jul 29, 2020, at 4:05 PM, Andrii Nakryiko <andr...@fb.com> wrote:
> 
> Add info on link detach sub-command to man page. Add detach to bash-completion
> as well.
> 
> Signed-off-by: Andrii Nakryiko <andr...@fb.com>

Acked-by: Song Liu <songliubrav...@fb.com>

With one nitpick below. 

> ---

[...]

> @@ -49,6 +50,13 @@ DESCRIPTION
>                 contain a dot character ('.'), which is reserved for future
>                 extensions of *bpffs*.
> 
> +     **bpftool link detach** *LINK*
> +               Force-detach link *LINK*. BPF link and its underlying BPF
> +               program will stay valid, but they will be detached from the
> +               respective BPF hook and BPF link will transition into
> +               a defunct state until last open file descriptor for that

Shall we say "a defunct state when the last open file descriptor for that..."?


> +               link is closed.
> +
>       **bpftool link help**
>                 Print short help message.
> 

[...]