Hi Igor, I love your patch! Yet something to improve:
[auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Igor-Russkikh/qed-introduce-devlink-health-support/20200728-024531 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git a57066b1a01977a646145f4ce8dfb4538b08368a config: mips-allyesconfig (attached as .config) compiler: mips-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=mips If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <l...@intel.com> All error/warnings (new ones prefixed by >>): drivers/net/ethernet/qlogic/qed/qed_devlink.c: In function 'qed_fw_fatal_reporter_dump': >> drivers/net/ethernet/qlogic/qed/qed_devlink.c:53:19: error: implicit >> declaration of function 'vzalloc'; did you mean 'kvzalloc'? >> [-Werror=implicit-function-declaration] 53 | p_dbg_data_buf = vzalloc(dbg_data_buf_size); | ^~~~~~~ | kvzalloc >> drivers/net/ethernet/qlogic/qed/qed_devlink.c:53:17: warning: assignment to >> 'u8 *' {aka 'unsigned char *'} from 'int' makes pointer from integer without >> a cast [-Wint-conversion] 53 | p_dbg_data_buf = vzalloc(dbg_data_buf_size); | ^ >> drivers/net/ethernet/qlogic/qed/qed_devlink.c:63:3: error: implicit >> declaration of function 'vfree'; did you mean 'kvfree'? >> [-Werror=implicit-function-declaration] 63 | vfree(p_dbg_data_buf); | ^~~~~ | kvfree cc1: some warnings being treated as errors vim +53 drivers/net/ethernet/qlogic/qed/qed_devlink.c 33 34 static int 35 qed_fw_fatal_reporter_dump(struct devlink_health_reporter *reporter, 36 struct devlink_fmsg *fmsg, void *priv_ctx, 37 struct netlink_ext_ack *extack) 38 { 39 struct qed_devlink *qdl = devlink_health_reporter_priv(reporter); 40 struct qed_fw_fatal_ctx *fw_fatal_ctx = priv_ctx; 41 struct qed_dev *cdev = qdl->cdev; 42 u32 dbg_data_buf_size; 43 u8 *p_dbg_data_buf; 44 int err; 45 46 /* Having context means that was a dump request after fatal, 47 * so we enable extra debugging while gathering the dump, 48 * just in case 49 */ 50 cdev->print_dbg_data = fw_fatal_ctx ? true : false; 51 52 dbg_data_buf_size = qed_dbg_all_data_size(cdev); > 53 p_dbg_data_buf = vzalloc(dbg_data_buf_size); 54 if (!p_dbg_data_buf) { 55 DP_NOTICE(cdev, 56 "Failed to allocate memory for a debug data buffer\n"); 57 return -ENOMEM; 58 } 59 60 err = qed_dbg_all_data(cdev, p_dbg_data_buf); 61 if (err) { 62 DP_NOTICE(cdev, "Failed to obtain debug data\n"); > 63 vfree(p_dbg_data_buf); 64 return err; 65 } 66 67 err = devlink_fmsg_binary_pair_put(fmsg, "dump_data", 68 p_dbg_data_buf, dbg_data_buf_size); 69 70 vfree(p_dbg_data_buf); 71 72 return err; 73 } 74 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
