Re: [PATCH v1 0/2] ptp: Add generic header parsing function

[Kurt Kanzenbach]

On Fri Jul 24 2020, Richard Cochran wrote:
> On Fri, Jul 24, 2020 at 08:25:59AM +0200, Kurt Kanzenbach wrote:
>> |static inline u8 ptp_get_msgtype(const struct ptp_header *hdr, unsigned int 
>> type)
>> |{
>> |    u8 msg;
>> |
>> |    if (unlikely(type & PTP_CLASS_V1))
>> |            /* msg type is located @ offset 20 for ptp v1 */ 
>> |            msg = hdr->source_port_identity.clock_identity.id[0];
>> |    else
>> |            msg = hdr->tsmt & 0x0f;
>> |
>> |    return msg;
>> |}
>> 
>> What do you think about it?
>
> Looks good.

OK, I'll add it.

>
> I can also test the dp83640.  Maybe you could test the cpts on a bbb?

Most likely, yes.

Thanks,
Kurt

signature.asc
Description: PGP signature