Re: [PATCH v1 2/2] net: dsa: mv88e6xxx: Use generic ptp header parsing function

[Richard Cochran]

On Thu, Jul 23, 2020 at 09:49:46AM +0200, Kurt Kanzenbach wrote:
> @@ -26,6 +26,7 @@ config NET_DSA_MV88E6XXX_PTP
>       depends on NET_DSA_MV88E6XXX_GLOBAL2
>       depends on PTP_1588_CLOCK
>       imply NETWORK_PHY_TIMESTAMPING
> +     select NET_PTP_CLASSIFY

Hm, PTP_1588_CLOCK already selects NET_PTP_CLASSIFY,

  config PTP_1588_CLOCK
        tristate "PTP clock support"
        depends on NET && POSIX_TIMERS
        select PPS
        select NET_PTP_CLASSIFY

and so I expect that the 'select' in NET_DSA_MV88E6XXX_PTP isn't
needed.  What am I missing?

Thanks,
Richard