> -----Original Message----- > From: Jakub Kicinski <[email protected]> > Sent: Tuesday, July 21, 2020 11:32 AM > To: Nguyen, Anthony L <[email protected]> > Cc: [email protected]; Michael, Alice <[email protected]>; > [email protected]; [email protected]; [email protected]; > Kirsher, Jeffrey T <[email protected]>; Brady, Alan > <[email protected]>; Burra, Phani R <[email protected]>; Hay, > Joshua A <[email protected]>; Chittim, Madhu > <[email protected]>; Linga, Pavan Kumar > <[email protected]>; Skidmore, Donald C > <[email protected]>; Brandeburg, Jesse > <[email protected]>; Samudrala, Sridhar > <[email protected]> > Subject: Re: [net-next v4 06/15] iecm: Implement mailbox functionality > > On Mon, 20 Jul 2020 17:38:01 -0700 Tony Nguyen wrote: > > + struct iecm_adapter *adapter = vport->adapter; > > + netdev_features_t dflt_features; > > + netdev_features_t offloads = 0; > > + struct iecm_netdev_priv *np; > > + struct net_device *netdev; > > + int err; > > + > > + netdev = alloc_etherdev_mqs(sizeof(struct iecm_netdev_priv), > > + IECM_MAX_Q, IECM_MAX_Q); > > + if (!netdev) > > + return -ENOMEM; > > + vport->netdev = netdev; > > + np = netdev_priv(netdev); > > + np->vport = vport; > > > + /* register last */ > > + err = register_netdev(netdev); > > + if (err) > > + return err; > > aren't you leaking the netdev here?
Certainly yes. Will fix. Alan
