> -----Original Message----- > From: Jakub Kicinski <k...@kernel.org> > Sent: Tuesday, July 21, 2020 11:32 AM > To: Nguyen, Anthony L <anthony.l.ngu...@intel.com> > Cc: da...@davemloft.net; Michael, Alice <alice.mich...@intel.com>; > netdev@vger.kernel.org; nhor...@redhat.com; sassm...@redhat.com; > Kirsher, Jeffrey T <jeffrey.t.kirs...@intel.com>; Brady, Alan > <alan.br...@intel.com>; Burra, Phani R <phani.r.bu...@intel.com>; Hay, > Joshua A <joshua.a....@intel.com>; Chittim, Madhu > <madhu.chit...@intel.com>; Linga, Pavan Kumar > <pavan.kumar.li...@intel.com>; Skidmore, Donald C > <donald.c.skidm...@intel.com>; Brandeburg, Jesse > <jesse.brandeb...@intel.com>; Samudrala, Sridhar > <sridhar.samudr...@intel.com> > Subject: Re: [net-next v4 06/15] iecm: Implement mailbox functionality > > On Mon, 20 Jul 2020 17:38:01 -0700 Tony Nguyen wrote: > > + struct iecm_adapter *adapter = vport->adapter; > > + netdev_features_t dflt_features; > > + netdev_features_t offloads = 0; > > + struct iecm_netdev_priv *np; > > + struct net_device *netdev; > > + int err; > > + > > + netdev = alloc_etherdev_mqs(sizeof(struct iecm_netdev_priv), > > + IECM_MAX_Q, IECM_MAX_Q); > > + if (!netdev) > > + return -ENOMEM; > > + vport->netdev = netdev; > > + np = netdev_priv(netdev); > > + np->vport = vport; > > > + /* register last */ > > + err = register_netdev(netdev); > > + if (err) > > + return err; > > aren't you leaking the netdev here?
Certainly yes. Will fix. Alan
