On Mon, 20 Jul 2020 17:38:01 -0700 Tony Nguyen wrote: > + struct iecm_adapter *adapter = vport->adapter; > + netdev_features_t dflt_features; > + netdev_features_t offloads = 0; > + struct iecm_netdev_priv *np; > + struct net_device *netdev; > + int err; > + > + netdev = alloc_etherdev_mqs(sizeof(struct iecm_netdev_priv), > + IECM_MAX_Q, IECM_MAX_Q); > + if (!netdev) > + return -ENOMEM; > + vport->netdev = netdev; > + np = netdev_priv(netdev); > + np->vport = vport;
> + /* register last */ > + err = register_netdev(netdev); > + if (err) > + return err; aren't you leaking the netdev here? > + return 0;