On Tue, May 19, 2020 at 09:51:59AM +0200, Oleksij Rempel wrote:
> Signal Quality Index is a mandatory value required by "OPEN Alliance
> SIG" for the 100Base-T1 PHYs [1]. This indicator can be used for cable
> integrity diagnostic and investigating other noise sources and
> implement by at least two vendors: NXP[2] and TI[3].
Hi Oleksij
With a multi part patch set, please always include a cover note,
describing what the patchset as a whole does.
> +int __ethtool_get_sqi(struct net_device *dev)
> +{
> + struct phy_device *phydev = dev->phydev;
> +
> + if (!phydev->drv->get_sqi)
> + return -EOPNOTSUPP;
> +
> + return phydev->drv->get_sqi(phydev);
> +}
You are not doing any locking here, which you should. Due to modules
vs built in, it can be a bit tricky getting this right. Take a look at
how ethtool ioctl.c uses phy_ethtool_get_stats() and that inline
function itself.
Andrew
