On Tue, 12 May 2020 at 02:11, David Miller <da...@davemloft.net> wrote: > > From: Vladimir Oltean <olte...@gmail.com> > Date: Tue, 12 May 2020 01:44:53 +0300 > > > On Tue, 12 May 2020 at 01:40, Jakub Kicinski <k...@kernel.org> wrote: > >> > >> On Mon, 11 May 2020 23:20:45 +0300 Vladimir Oltean wrote: > >> > From: Vladimir Oltean <vladimir.olt...@nxp.com> > >> > > >> > There are 2 goals that we follow: > >> > > >> > - Reduce the header size > >> > - Make the header size equal between RX and TX > >> > >> Getting this from sparse: > >> > >> ../net/dsa/tag_ocelot.c:185:17: warning: incorrect type in assignment > >> (different base types) > >> ../net/dsa/tag_ocelot.c:185:17: expected unsigned int [usertype] > >> ../net/dsa/tag_ocelot.c:185:17: got restricted __be32 [usertype] > > > > I hate this warning :( > > You hate that endianness bugs are caught automatically? :-) >
Well, there's no bug here, really, what's annoying is that it's warning me when a convention is not being followed. It would have been smarter if it just limited itself to the situations when not following that convention actually causes a problem.