Re: [PATCH net-next 2/4] net: dsa: sja1105: request promiscuous mode for master

[Florian Fainelli]

On 5/11/2020 1:20 PM, Vladimir Oltean wrote:
> From: Vladimir Oltean <vladimir.olt...@nxp.com>
> 
> Currently PTP is broken when ports are in standalone mode (the tagger
> keeps printing this message):
> 
> sja1105 spi0.1: Expected meta frame, is  180c200000e in the DSA master 
> multicast filter?
> 
> Sure, one might say "simply add 01-80-c2-00-00-0e to the master's RX
> filter" but things become more complicated because:
> 
> - Actually all frames in the 01-80-c2-xx-xx-xx and 01-1b-19-xx-xx-xx
>   range are trapped to the CPU automatically
> - The switch mangles bytes 3 and 4 of the MAC address via the incl_srcpt
>   ("include source port [in the DMAC]") option, so an address installed
>   to the RX filter would, at the end of the day, not correspond to the
>   final address seen by the DSA master.
> 
> Assume RX filters on DSA masters are typically too small to include all
> necessary addresses for PTP to work properly on sja1105, and just
> request promiscuous mode unconditionally.
> 
> Signed-off-by: Vladimir Oltean <vladimir.olt...@nxp.com>

Reviewed-by: Florian Fainelli <f.faine...@gmail.com>
-- 
Florian