On Thu, 2020-04-30 at 11:22 +0300, Tariq Toukan wrote: > > On 4/30/2020 3:12 AM, Jakub Kicinski wrote: > > On Wed, 29 Apr 2020 15:54:49 -0700 Saeed Mahameed wrote: > > > From: Tariq Toukan <tar...@mellanox.com> > > > > > > SKBs of TLS records might have empty zero-sized frags. > > > > Why? Let's fix that instead of adding checks to drivers. > > > > Hi Jakub, > > The HW spec requires the DUMP size to be non-zero, this patch comes > to > guarantee this in driver. > In kernel stack, having zero-side fragments is for sure non-optimal > practice, but still could be considered valid and tolerated. > I agree that we should find the source of this practice in stack and > enhance it. >
Ok then, let's find the source, i will drop this patch for now.. We should aim for less driver code duplication, if this is something that can be guaranteed by the ktls stack.
