On 4/30/2020 3:12 AM, Jakub Kicinski wrote:
On Wed, 29 Apr 2020 15:54:49 -0700 Saeed Mahameed wrote:
From: Tariq Toukan <tar...@mellanox.com>

SKBs of TLS records might have empty zero-sized frags.

Why? Let's fix that instead of adding checks to drivers.


Hi Jakub,

The HW spec requires the DUMP size to be non-zero, this patch comes to guarantee this in driver. In kernel stack, having zero-side fragments is for sure non-optimal practice, but still could be considered valid and tolerated. I agree that we should find the source of this practice in stack and enhance it.

Thanks,
Tariq

Posting a DUMP WQE for such frag would result an error completion.
Add in-driver resiliency and skip such frags.

Fixes: d2ead1f360e8 ("net/mlx5e: Add kTLS TX HW offload support")

Reply via email to