On Wed, Aug 21, 2019 at 11:27 AM Vlad Buslov <vla...@mellanox.com> wrote:
> At first I was confused why you bring up rtnl lock in commit message
> (flower classifier has 'unlocked' flag set and can't rely on it anymore)
> but looking at the code I see that we lost rcu read lock here in commit
> d39d714969cd ("idr: introduce idr_for_each_entry_continue_ul()") and you
> are correctly bringing it back. Adding Cong to advise if it is okay to
> wait for this patch to be accepted or we need to proceed with fixing the
> missing RCU lock as a standalone patch.Hmm? Isn't ->walk() still called with RTNL lock? tcf_chain_dump() calls __tcf_get_next_proto() which asserts RTNL. So why does it still need RCU read lock when having RTNL?
