On Thu, 8 Aug 2019 20:22:00 +0000, Saeed Mahameed wrote: > From: Maxim Mikityanskiy <maxi...@mellanox.com> > > The current ARFS code relies on certain fields to be set in the SKB > (e.g. transport_header) and extracts IP addresses and ports by custom > code that parses the packet. The necessary SKB fields, however, are not > always set at that point, which leads to an out-of-bounds access. Use > skb_flow_dissect_flow_keys() to get the necessary information reliably, > fix the out-of-bounds access and reuse the code.
The whole series LGTM, FWIW. I'd be curious to hear which path does not have the skb fully set up, could you elaborate? (I'm certainly no aRFC expert this is pure curiosity).
