> -----Original Message-----
> From: Jiri Pirko <[email protected]>
> Sent: Wednesday, July 3, 2019 8:05 PM
> To: Andrew Lunn <[email protected]>
> Cc: Parav Pandit <[email protected]>; Jakub Kicinski
> <[email protected]>; Jiri Pirko <[email protected]>;
> [email protected]; Saeed Mahameed <[email protected]>;
> [email protected]; [email protected]
> Subject: Re: [PATCH net-next 1/3] devlink: Introduce PCI PF port flavour and
> port attribute
> 
> Wed, Jul 03, 2019 at 04:09:58PM CEST, [email protected] wrote:
> >> However, we expose it for DEVLINK_PORT_FLAVOUR_CPU and
> >> DEVLINK_PORT_FLAVOUR_DSA. Not sure if it makes sense there either.
> >> Ccing Florian, Andrew and Vivien.
> >> What do you guys think?
> >
> >Hi Jiri
> >
> >DSA and CPU ports are physical ports of the switch. And there can be
> >multiple DSA ports, and maybe sometime real soon now, multiple CPU
> >ports. So having a number associated with them is useful.
> 
> Okay. Makes sense.
> 
Ok. I should probably update the comment section for port_number as its scope 
is expanded.
Should I revise the series with updated comment?

> >
> >       Andrew

Reply via email to