On Tue, 2 Jul 2019 18:50:31 +0000, Parav Pandit wrote: > > > I didn't see any immediate need to report, at the same time didn't > > > find any reason to treat such port flavours differently than existing > > > one. It just gives a clear view of the device's eswitch. Might find it > > > useful during debugging while inspecting device internal tables.. > > > > PFs and VFs ports are not tied to network ports in switchdev mode. > > You have only one network port under a devlink instance AFAIR, anyway. > > > I am not sure what do you mean by network port.
DEVLINK_PORT_FLAVOUR_PHYSICAL > Do you intent to see a physical port that connects to physical network? > > As I described in the comment of the PF and VF flavour, it is an eswitch port. > I have shown the diagram also of the eswitch in the cover letter. > Port_number doesn't have to a physical port. Flavour describe what > port type is and number says what is the eswitch port number. > Hope it clarifies. I understand what you're doing. If you want to expose some device specific eswitch port ID please add a new attribute for that. The fact that that ID may match port_number for your device today is coincidental. port_number, and split attributes should not be exposed for PCI ports.
