> -----Original Message----- > From: Jakub Kicinski <jakub.kicin...@netronome.com> > Sent: Tuesday, June 18, 2019 4:24 AM > To: Sudarsana Reddy Kalluru <skall...@marvell.com> > Cc: da...@davemloft.net; netdev@vger.kernel.org; Michal Kalderon > <mkalde...@marvell.com>; Ariel Elior <ael...@marvell.com>; Jiri Pirko > <j...@resnulli.us> > Subject: [EXT] Re: [PATCH net-next 4/4] qed: Add devlink support for > configuration attributes. > > External Email > > ---------------------------------------------------------------------- > On Mon, 17 Jun 2019 04:45:28 -0700, Sudarsana Reddy Kalluru wrote: > > This patch adds implementation for devlink callbacks for reading/ > > configuring the device attributes. > > > > Signed-off-by: Sudarsana Reddy Kalluru <skall...@marvell.com> > > Signed-off-by: Ariel Elior <ael...@marvell.com> > > You need to provide documentation for your parameters, plus some of them > look like they should potentially be port params, not device params.
Thanks a lot for your review. Will add the required documentation. In case of Marvell adapter, any of the device/adapter/port parameters can be read/configurable via any PF (ethdev) on the port. Hence adding the commands at device level. Hope this is fine.
