On Mon, 17 Jun 2019 04:45:28 -0700, Sudarsana Reddy Kalluru wrote: > This patch adds implementation for devlink callbacks for reading/ > configuring the device attributes. > > Signed-off-by: Sudarsana Reddy Kalluru <skall...@marvell.com> > Signed-off-by: Ariel Elior <ael...@marvell.com>
You need to provide documentation for your parameters, plus some of them look like they should potentially be port params, not device params.
