On 4/17/2019 7:31 PM, Andrew Lunn wrote: > It is possible that the driver is compiled with both > CONFIG_NET_DSA_TAG_BRCM and CONFIG_NET_DSA_TAG_BRCM_PREPEND disabled. > This results in warnings about unused symbols. Add some conditional > compilation to avoid this. > > Signed-off-by: Andrew Lunn <and...@lunn.ch> Reviewed-by: Florian Fainelli <f.faine...@gmail.com> Would not you want to re-order this patch such that it comes before patch 14 and there is not possibility of generating unused symbols warnings? -- Florian
- Re: [PATCH net-next 14/15] dsa: Allow tag drivers to... Florian Fainelli
- [PATCH net-next 09/15] dsa: Register the none tagger ops Andrew Lunn
- Re: [PATCH net-next 09/15] dsa: Register the none ta... Florian Fainelli
- [PATCH net-next 05/15] dsa: Add TAG protocol to tag ops Andrew Lunn
- Re: [PATCH net-next 05/15] dsa: Add TAG protocol to ... Florian Fainelli
- [PATCH net-next 02/15] dsa: Move tagger name into its ops... Andrew Lunn
- Re: [PATCH net-next 02/15] dsa: Move tagger name int... Florian Fainelli
- [PATCH net-next 13/15] dsa: Cleanup unneeded table and ma... Andrew Lunn
- Re: [PATCH net-next 13/15] dsa: Cleanup unneeded tab... Florian Fainelli
- [PATCH net-next 15/15] dsa: tag_brcm: Avoid unused symbol... Andrew Lunn
- Re: [PATCH net-next 15/15] dsa: tag_brcm: Avoid unus... Florian Fainelli
- [PATCH net-next 01/15] dsa: Add SPDX header to tag driver... Andrew Lunn
- Re: [PATCH net-next 01/15] dsa: Add SPDX header to t... Florian Fainelli
- [PATCH net-next 03/15] dsa: Add MODULE_ALIAS to taggers i... Andrew Lunn
- Re: [PATCH net-next 03/15] dsa: Add MODULE_ALIAS to ... Florian Fainelli
- [PATCH net-next 11/15] dsa: Add stub tag driver put metho... Andrew Lunn
- Re: [PATCH net-next 11/15] dsa: Add stub tag driver ... Florian Fainelli
- [PATCH net-next 12/15] dsa: Make use of the list of tag d... Andrew Lunn
- Re: [PATCH net-next 12/15] dsa: Make use of the list... Florian Fainelli
- [PATCH net-next 07/15] dsa: Add boilerplate helper to reg... Andrew Lunn
- Re: [PATCH net-next 07/15] dsa: Add boilerplate help... Florian Fainelli