Re: [PATCH net-next 11/15] dsa: Add stub tag driver put method

[Florian Fainelli]

On 4/17/2019 7:31 PM, Andrew Lunn wrote:
> When a DSA switch driver is unloaded, the lock on the tag driver
> should be released so the module can be unloaded. Add the needed calls,
> but leave the actual relase code as a stub.
> 
> Signed-off-by: Andrew Lunn <and...@lunn.ch>
> ---

[snip]

> diff --git a/net/dsa/dsa2.c b/net/dsa/dsa2.c
> index ba91bda8bdd3..efc51a9dc9c8 100644
> --- a/net/dsa/dsa2.c
> +++ b/net/dsa/dsa2.c
> @@ -335,6 +335,8 @@ static void dsa_port_teardown(struct dsa_port *dp)
>       case DSA_PORT_TYPE_UNUSED:
>               break;
>       case DSA_PORT_TYPE_CPU:
> +             dsa_tag_driver_put(dp->tag_ops);
> +             /* fall thought */

Typo: s/fall thought/fall through/

Reviewed-by: Florian Fainelli <f.faine...@gmail.com>
-- 
Florian