Hi Andrew,

> Is this a single chip MAC/PHY, or is there a discrete PHY?
> 
> If this is not a single chip solution, maybe this should be called
> get_phy_temp, so you can later add a get_mac_temp.

Thats a single chip with integrated mac/phy.
I however double checked it, and see phy and mac report temperatures separately.
So its really better to name it phy_temp. And I'll investigate on mac_temp 
later.

> To bring this up to par with the aquantia PHY driver, you might want
> to also export the high/low warn and fail temperatures.

Ok, will investigate this.

Regards, Igor

Reply via email to